DP-5320 - Read hyperlinks from Excel#229
Merged
DeleTaylor merged 4 commits intomasterfrom Nov 25, 2025
Merged
Conversation
gvjoshi25
requested review from
Bryan-Noel,
DeleTaylor,
chlocarlos and
yaphet17
DeleTaylor
requested changes
Nov 24, 2025
src/main/java/com/northconcepts/datapipeline/examples/cookbook/ReaderHyperlinksFromExcel.java
Outdated
Show resolved
Hide resolved
src/main/java/com/northconcepts/datapipeline/examples/cookbook/ReaderHyperlinksFromExcel.java
Outdated
Show resolved
Hide resolved
src/main/java/com/northconcepts/datapipeline/examples/cookbook/ReaderHyperlinksFromExcel.java
Outdated
Show resolved
Hide resolved
src/main/java/com/northconcepts/datapipeline/examples/cookbook/ReaderHyperlinksFromExcel.java
Outdated
Show resolved
Hide resolved
DeleTaylor
requested changes
Nov 24, 2025
src/main/java/com/northconcepts/datapipeline/examples/cookbook/ReaderHyperlinksFromExcel.java
Outdated
Show resolved
Hide resolved
DeleTaylor
requested changes
Nov 25, 2025
| Field field = record.getField("product_name"); | ||
| metadata.setField(field); | ||
|
|
||
| record.addField("product_link", metadata.getExcelHyperlink() == null ? null : metadata.getExcelHyperlink().getLocation()); |
Contributor
There was a problem hiding this comment.
Let's still hold metadata.getExcelHyperlink() in a local variable to prevent the multiple session Map lookups -- since this kind of thing can slow down a multi-million record pipeline.
DeleTaylor
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.